Update install instructions, for release of sourmash 2.0 #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Suggestion: during the 'hunting down docs', keep a list (in an issue?) with locations! (So we don't need to hunt them down again) Also: if we want to point to a specific branch for workshops, let's tag it and install the tag... So instead of we do |
|
good idea! although I think I prefer putting in a search tag in each location
;).
turns out there aren't any other places than where I mentioned, AFAICT.
|
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
=======================================
Coverage 89.47% 89.47%
=======================================
Files 27 27
Lines 4238 4238
Branches 39 39
=======================================
Hits 3792 3792
Misses 446 446Continue to review full report at Codecov.
|
This was referenced Jan 9, 2019
luizirber
approved these changes
Mar 22, 2019
luizirber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we have a splendiferous sourmash 2.0 release, we need to update install instructions appropriately!
This is currently a merge into #591. This branch should not be merged until we're ready to release sourmash 2.0.
Fixes #592 #425 #159 #521.
TODO:
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?